Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zod-openapi] Merge subapps' definitions into main app #153

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

mikestopcontinues
Copy link
Contributor

Three features are included in this PR:

  1. You can pass init options to OpenAPIHono (fixes [Zod OpenAPI] accept args in the constructor #152)
  2. You can generate OpenAPI v3.1 spec
  3. You can merge the spec definitions of nested OpenAPIHono routers

If you would prefer to handle these separately, they're in clean, distinct commits.

New tests cover all new functionality. No old tests changed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2023

🦋 Changeset detected

Latest commit: d9ea3fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @mikestopcontinues !

Great work! This is what we want. I've reviewed the all code, but there is no problem. Let's ship it! Thanks!

@yusukebe yusukebe merged commit 430088e into honojs:main Sep 11, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Zod OpenAPI] accept args in the constructor
2 participants